Debug.gemを使ったコード修正 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedana
reviewed
Jun 8, 2023
| @@ -30,5 +30,5 @@ def take_order(menus) | |||
| puts 'フードメニューはいかがですか?' | |||
| order2 = take_order(FOODS) | |||
|
|
|||
| total = FOODS[order1][:price] + DRINKS[order2][:price] | |||
| total = FOODS[order2][:price] + DRINKS[order1][:price] | |||
There was a problem hiding this comment.
動作的には問題ないのですけど、本質的にはorder1やorder2というわかりにくい命名をしていることがこの種の不具合を生む原因になったりします。従ってよりよい回答を目指すのならこのわかりにくい変数名をわかりやすくするのが望ましいです。
There was a problem hiding this comment.
ロジックのエラーばかり気にしていて変数の不明瞭さは盲点でした。
今後気をつけていきたいと思います！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.