管理ページの企業一覧を非React化した #8230
Open
管理ページの企業一覧を非React化した #8230
+31
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
管理ページの企業一覧ページを非React化しました。
views/admin/companies/index.html.slimで使用されているReactコンポーネントAdminCompanies.jsxを削除し、view内で完結するようにしました。変更確認方法
chore/company-list-non-vue-reactをローカルに取り込むi.
git fetch origin pull/8230/head:chore/company-list-non-vue-reactii.
git checkout chore/company-list-non-vue-reactforeman start -f Procfile.devでローカルサーバーを立ち上げるkomagata、パスワードtesttestでログインするScreenshot
今回の変更に伴う画面変更はありません。