Skip to content

Commit

Permalink
Apply PR fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
fivetran-avinash committed Aug 8, 2023
1 parent 677f27e commit 1f21f52
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 8 deletions.
10 changes: 7 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# dbt_salesforce_formula_utils v0.9.2
## Documentation Update
- Fivetran will be deprecating support for Options 2 and 3 by October 1 where you can set `full_statement_version=false`. We've highlighted this change to users of the package [in the README](https://github.com/fivetran/dbt_salesforce_formula_utils#step-4-create-models).
- Users still utilizing either Option 2 or 3 will receive a log message in their `dbt run` indicating deprecation of support for those options.
[PR #96](https://github.com/fivetran/dbt_salesforce_formula_utils/pull/96) includes the following updates:

## 🗒️ Documentation Update 🗒️
- Fivetran will be deprecating support for the `full_statement_version=false` config by October 1, 2023. We've highlighted this change to users of the package [in the README](https://github.com/fivetran/dbt_salesforce_formula_utils#step-4-create-models).

## 🚇 Under the Hood 🚇
- Users still utilizing the `full_statement_version=false` config will receive a log message in their `dbt run` indicating deprecation of support for those options.

# dbt_salesforce_formula_utils v0.9.1
## Bugfix
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ If you would like your model to generate all the formula fields at once related

### (Deprecated) Options 2 and 3

IMPORTANT: Options 2 and 3 will no longer be supported after October 1. Click 'Expand to view details' if you'd like to still use these options for the time being.
**IMPORTANT**: Options 2 and 3 (which leverage the `full_statement_version=false` config) will no longer be supported after October 1. Click 'Expand to view details' if you'd like to still use these options for the time being.

<details>
<summary>Expand to view details</summary>
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"metadata": {"dbt_schema_version": "https://schemas.getdbt.com/dbt/run-results/v4.json", "dbt_version": "1.6.0", "generated_at": "2023-08-08T02:21:34.096217Z", "invocation_id": "fc502852-a89e-4f07-b241-7901cc453e7b", "env": {}}, "results": [{"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:30.884032Z", "completed_at": "2023-08-08T02:21:31.850437Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:31.851015Z", "completed_at": "2023-08-08T02:21:31.851028Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 1.0919668674468994, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.opportunity_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:30.854976Z", "completed_at": "2023-08-08T02:21:31.872750Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:31.873382Z", "completed_at": "2023-08-08T02:21:31.873388Z"}], "thread_id": "Thread-1 (worker)", "execution_time": 1.1275269985198975, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.account_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:30.867855Z", "completed_at": "2023-08-08T02:21:32.412111Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:32.415474Z", "completed_at": "2023-08-08T02:21:32.415484Z"}], "thread_id": "Thread-2 (worker)", "execution_time": 1.66225004196167, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.account_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:30.886653Z", "completed_at": "2023-08-08T02:21:32.411770Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:32.414602Z", "completed_at": "2023-08-08T02:21:32.414623Z"}], "thread_id": "Thread-4 (worker)", "execution_time": 1.6677639484405518, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.opportunity_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:31.947095Z", "completed_at": "2023-08-08T02:21:32.900218Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:32.901746Z", "completed_at": "2023-08-08T02:21:32.901763Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 1.0553417205810547, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_role_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:33.005371Z", "completed_at": "2023-08-08T02:21:33.007408Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.008302Z", "completed_at": "2023-08-08T02:21:33.008307Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.005228996276855469, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.account"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:33.010692Z", "completed_at": "2023-08-08T02:21:33.011675Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.012245Z", "completed_at": "2023-08-08T02:21:33.012249Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.00321197509765625, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.fivetran_formula"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:33.013908Z", "completed_at": "2023-08-08T02:21:33.015412Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.015913Z", "completed_at": "2023-08-08T02:21:33.015917Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.002952098846435547, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.fivetran_formula_model"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:33.017667Z", "completed_at": "2023-08-08T02:21:33.018619Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.019219Z", "completed_at": "2023-08-08T02:21:33.019224Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.002540111541748047, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.opportunity"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:33.020867Z", "completed_at": "2023-08-08T02:21:33.021776Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.022200Z", "completed_at": "2023-08-08T02:21:33.022204Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.002231121063232422, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.user"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:33.023863Z", "completed_at": "2023-08-08T02:21:33.024803Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.025360Z", "completed_at": "2023-08-08T02:21:33.025366Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.002599954605102539, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.user_role"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:31.981180Z", "completed_at": "2023-08-08T02:21:33.385351Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.389323Z", "completed_at": "2023-08-08T02:21:33.389332Z"}], "thread_id": "Thread-1 (worker)", "execution_time": 1.515244722366333, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_role_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:32.516085Z", "completed_at": "2023-08-08T02:21:33.477873Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.478379Z", "completed_at": "2023-08-08T02:21:33.478384Z"}], "thread_id": "Thread-2 (worker)", "execution_time": 1.0567779541015625, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T02:21:32.522928Z", "completed_at": "2023-08-08T02:21:33.944967Z"}, {"name": "execute", "started_at": "2023-08-08T02:21:33.946891Z", "completed_at": "2023-08-08T02:21:33.946908Z"}], "thread_id": "Thread-4 (worker)", "execution_time": 1.5331408977508545, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_view"}], "elapsed_time": 6.1946728229522705, "args": {"print": true, "defer": false, "project_dir": "/Users/avinash.kunnath/Documents/dbt_packages/salesforce_formula_utils/dbt_salesforce_formula_utils/integration_tests", "log_format": "default", "enable_legacy_logger": false, "indirect_selection": "eager", "use_colors_file": true, "log_path": "/Users/avinash.kunnath/Documents/dbt_packages/salesforce_formula_utils/dbt_salesforce_formula_utils/integration_tests/logs", "exclude": [], "printer_width": 80, "favor_state": false, "populate_cache": true, "macro_debugging": false, "select": [], "send_anonymous_usage_stats": true, "quiet": false, "which": "generate", "static_parser": true, "strict_mode": false, "introspect": true, "compile": true, "log_file_max_bytes": 10485760, "empty_catalog": false, "use_colors": true, "partial_parse": true, "log_level": "info", "profiles_dir": "/Users/avinash.kunnath/.dbt", "version_check": true, "write_json": true, "target": "postgres", "cache_selected_only": false, "warn_error_options": {"include": [], "exclude": []}, "log_format_file": "debug", "log_level_file": "debug", "invocation_command": "dbt docs generate -t postgres", "vars": {}}}
{"metadata": {"dbt_schema_version": "https://schemas.getdbt.com/dbt/run-results/v4.json", "dbt_version": "1.6.0", "generated_at": "2023-08-08T18:22:11.186335Z", "invocation_id": "d8d7e46d-bb6d-45da-9073-0acc06c08d7d", "env": {}}, "results": [{"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:07.250768Z", "completed_at": "2023-08-08T18:22:08.480834Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:08.481482Z", "completed_at": "2023-08-08T18:22:08.481495Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 1.373094081878662, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.opportunity_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:07.222813Z", "completed_at": "2023-08-08T18:22:08.538275Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:08.538712Z", "completed_at": "2023-08-08T18:22:08.538719Z"}], "thread_id": "Thread-1 (worker)", "execution_time": 1.4241516590118408, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.account_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:07.244739Z", "completed_at": "2023-08-08T18:22:09.106983Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.107886Z", "completed_at": "2023-08-08T18:22:09.107890Z"}], "thread_id": "Thread-2 (worker)", "execution_time": 1.9921491146087646, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.account_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:07.253191Z", "completed_at": "2023-08-08T18:22:09.106538Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.107644Z", "completed_at": "2023-08-08T18:22:09.107651Z"}], "thread_id": "Thread-4 (worker)", "execution_time": 1.9913380146026611, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.opportunity_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:08.595152Z", "completed_at": "2023-08-08T18:22:09.630925Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.631761Z", "completed_at": "2023-08-08T18:22:09.631772Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 1.1709909439086914, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_role_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.768798Z", "completed_at": "2023-08-08T18:22:09.770075Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.770650Z", "completed_at": "2023-08-08T18:22:09.770656Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.003179788589477539, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.account"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.772465Z", "completed_at": "2023-08-08T18:22:09.773502Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.774122Z", "completed_at": "2023-08-08T18:22:09.774128Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.0027687549591064453, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.fivetran_formula"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.776432Z", "completed_at": "2023-08-08T18:22:09.777499Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.778018Z", "completed_at": "2023-08-08T18:22:09.778023Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.0028531551361083984, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.fivetran_formula_model"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.779916Z", "completed_at": "2023-08-08T18:22:09.782677Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.783532Z", "completed_at": "2023-08-08T18:22:09.783539Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.004770040512084961, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.opportunity"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.785640Z", "completed_at": "2023-08-08T18:22:09.786663Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.787186Z", "completed_at": "2023-08-08T18:22:09.787191Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.0027370452880859375, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.user"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.788996Z", "completed_at": "2023-08-08T18:22:09.790030Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:09.790567Z", "completed_at": "2023-08-08T18:22:09.790572Z"}], "thread_id": "Thread-3 (worker)", "execution_time": 0.0026640892028808594, "adapter_response": {}, "message": null, "failures": null, "unique_id": "seed.salesforce_formula_integration_tests.user_role"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:08.644893Z", "completed_at": "2023-08-08T18:22:10.342413Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:10.344144Z", "completed_at": "2023-08-08T18:22:10.344151Z"}], "thread_id": "Thread-1 (worker)", "execution_time": 1.8221628665924072, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_role_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.215875Z", "completed_at": "2023-08-08T18:22:10.473646Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:10.474227Z", "completed_at": "2023-08-08T18:22:10.474234Z"}], "thread_id": "Thread-2 (worker)", "execution_time": 1.4106402397155762, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_statement_view"}, {"status": "success", "timing": [{"name": "compile", "started_at": "2023-08-08T18:22:09.218488Z", "completed_at": "2023-08-08T18:22:11.014836Z"}, {"name": "execute", "started_at": "2023-08-08T18:22:11.016231Z", "completed_at": "2023-08-08T18:22:11.016247Z"}], "thread_id": "Thread-4 (worker)", "execution_time": 1.9671101570129395, "adapter_response": {}, "message": null, "failures": null, "unique_id": "model.salesforce_formula_integration_tests.user_view"}], "elapsed_time": 7.32912802696228, "args": {"cache_selected_only": false, "profiles_dir": "/Users/avinash.kunnath/.dbt", "send_anonymous_usage_stats": true, "exclude": [], "static_parser": true, "use_colors": true, "log_level_file": "debug", "vars": {}, "log_path": "/Users/avinash.kunnath/Documents/dbt_packages/salesforce_formula_utils/dbt_salesforce_formula_utils/integration_tests/logs", "print": true, "target": "postgres", "log_format_file": "debug", "log_level": "info", "introspect": true, "version_check": true, "macro_debugging": false, "which": "generate", "write_json": true, "log_file_max_bytes": 10485760, "select": [], "quiet": false, "strict_mode": false, "enable_legacy_logger": false, "use_colors_file": true, "compile": true, "printer_width": 80, "indirect_selection": "eager", "populate_cache": true, "partial_parse": true, "empty_catalog": false, "favor_state": false, "log_format": "default", "warn_error_options": {"include": [], "exclude": []}, "defer": false, "invocation_command": "dbt docs generate -t postgres", "project_dir": "/Users/avinash.kunnath/Documents/dbt_packages/salesforce_formula_utils/dbt_salesforce_formula_utils/integration_tests"}}
2 changes: 1 addition & 1 deletion macros/sfdc_formula_view.sql
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
{% set fields_to_include = current_formula_fields | lower %}
{% endif %}

{{ exceptions.warn("WARNING, Deprecated: full_statement_version=false is no longer supported and will stop working on October 1st, 2023. See https://github.com/fivetran/dbt_salesforce_formula_utils#step-4-create-models for more details.") }}
{{ exceptions.warn("\nWARNING, Deprecated: full_statement_version=false is no longer supported and will stop working on October 1st, 2023. Be sure to update your " ~ this.identifier|upper ~ " model to leverage full_statement_version=true before then. See https://github.com/fivetran/dbt_salesforce_formula_utils#step-4-create-models for more details.\n") }}

select

Expand Down

0 comments on commit 1f21f52

Please sign in to comment.