[Feature] Add created_at and updated at fields
#58
+140
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Thanks for these updates @fivetran-avinash, just a few change requests before approval.
CHANGELOG.md
Outdated
| [PR #58](https://github.com/fivetran/dbt_quickbooks_source/pull/57) introduces the following updates: | ||
|
|
||
| ## Breaking Changes | ||
| - We introduced these pre-existing timestamp fields from these sources to their equivalent staging models to better analyze real-time transaction data: |
There was a problem hiding this comment.
I would list the field and the exact staging models they were added to instead of requiring the user to have to match them up on their own.
Suggested change
| - We introduced these pre-existing timestamp fields from these sources to their equivalent staging models to better analyze real-time transaction data: | |
| - Introduced the following timestamp fields to the listed staging models to better analyze real-time transaction data: |
There was a problem hiding this comment.
@fivetran-catfritz Listing all the staging models would get a bit wordy, so I did a slight tweak to your suggestion. Let me know your thoughts.
There was a problem hiding this comment.
True--this makes sense!
CHANGELOG.md
Outdated
| - `created_at`: `bill`, `bill_payment`, `credit_memo`, `invoice`, `payment`, `transfer` | ||
| - `updated_at`: `bill`, `bill_payment`, `credit_memo`, `deposit`, `invoice`, `journal_entry`, `payment`, `purchase`, `refund_receipt`, `sales_receipt`, `transfer`, `vendor_credit` | ||
| - These new fields are then being brought in downstream in the `dbt_quickbooks` package in the `quickbooks__general_ledger` model via the double entry transaction intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). | ||
| - As this introduces new columns to our staging models and changes our schema, this will be a breaking change. |
There was a problem hiding this comment.
Suggested change
| - As this introduces new columns to our staging models and changes our schema, this will be a breaking change. | |
| - As this introduces new columns to our staging models and changes our schema, this is breaking change. |
CHANGELOG.md
Outdated
| - We introduced these pre-existing timestamp fields from these sources to their equivalent staging models to better analyze real-time transaction data: | ||
| - `created_at`: `bill`, `bill_payment`, `credit_memo`, `invoice`, `payment`, `transfer` | ||
| - `updated_at`: `bill`, `bill_payment`, `credit_memo`, `deposit`, `invoice`, `journal_entry`, `payment`, `purchase`, `refund_receipt`, `sales_receipt`, `transfer`, `vendor_credit` | ||
| - These new fields are then being brought in downstream in the `dbt_quickbooks` package in the `quickbooks__general_ledger` model via the double entry transaction intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). |
There was a problem hiding this comment.
Suggested change
| - These new fields are then being brought in downstream in the `dbt_quickbooks` package in the `quickbooks__general_ledger` model via the double entry transaction intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). | |
| - These new fields are incorporated in the `dbt_quickbooks` package's `quickbooks__general_ledger` model via the `*_double_entry` intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). |
fivetran-catfritz
approved these changes
Nov 25, 2024
CHANGELOG.md
Outdated
| - Introduced the following timestamp fields to the listed `stg_quickbooks__*` models to better analyze real-time transaction data: | ||
| - `created_at`: `bill`, `bill_payment`, `credit_memo`, `invoice`, `payment`, `transfer` | ||
| - `updated_at`: `bill`, `bill_payment`, `credit_memo`, `deposit`, `invoice`, `journal_entry`, `payment`, `purchase`, `refund_receipt`, `sales_receipt`, `transfer`, `vendor_credit` | ||
| - - These new fields are incorporated in the `dbt_quickbooks` package's `quickbooks__general_ledger` model via the `*_double_entry` intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). |
There was a problem hiding this comment.
Just noticed the double dash.
Suggested change
| - - These new fields are incorporated in the `dbt_quickbooks` package's `quickbooks__general_ledger` model via the `*_double_entry` intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). | |
| - These new fields are incorporated in the `dbt_quickbooks` package's `quickbooks__general_ledger` model via the `*_double_entry` intermediate models. You can learn more about these changes in the [v0.17.0 release of the `dbt_quickbooks` package](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.17.0). |
CHANGELOG.md
Outdated
| [PR #58](https://github.com/fivetran/dbt_quickbooks_source/pull/57) introduces the following updates: | ||
|
|
||
| ## Breaking Changes | ||
| - We introduced these pre-existing timestamp fields from these sources to their equivalent staging models to better analyze real-time transaction data: |
There was a problem hiding this comment.
True--this makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: #144 in dbt_quickbooks
This PR will result in the following new package version:
Added fields into various models, but nothing in particular will break for the customer I believe.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates
created_at:bill,bill_payment,credit_memo,invoice,payment,transferupdated_at:bill,bill_payment,credit_memo,deposit,invoice,journal_entry,payment,purchase,refund_receipt,sales_receipt,transfer,vendor_creditdbt_quickbookspackage in thequickbooks__general_ledgermodel via the double entry transaction intermediate models. You can learn more about these changes in the v0.17.0 release of thedbt_quickbookspackage.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Ensured the
created_atandupdated_atfields were being brought into the relevant models that were used in the double entry transaction models. Example:If you had to summarize this PR in an emoji, which would it be?
⌛