Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimize pass through all fields logic in staging models #102

Open
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Mar 29, 2023 · 0 comments
Open
1 of 4 tasks
Labels
priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Currently we are performing a conditional check within the deal, contact, company, and ticket models when the hubspot__pass_through_all_columns variable is set to true. This conditional check is not the driest or most elegant code we could use in this situation. I would like to propose a feature for us to clean this logic up a bit more and make a provide a dryer and more elegant solution.

Describe alternatives you've considered

Using the current version. It should work, but it is not very dry.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

This code was introduced within PR #

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:enhancement New functionality or enhancement label Mar 29, 2023
@fivetran-jamie fivetran-jamie added the priority:p4 Affects few users; pick up when available label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants