Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add connector_id to incremental_mar table #76

Open
2 of 4 tasks
pkanter opened this issue Feb 17, 2023 · 1 comment
Open
2 of 4 tasks

[Feature] Add connector_id to incremental_mar table #76

pkanter opened this issue Feb 17, 2023 · 1 comment
Labels
type:wontfix This will not be worked on

Comments

@pkanter
Copy link

pkanter commented Feb 17, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

It would be handy to have the connector_id in the incremental_mar table, rather than just the connector_name. connector_id was provided in the mar_table_history table.

Describe alternatives you've considered

The alternative is to join on the name, but not a best practice.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:enhancement New functionality or enhancement label Feb 21, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @pkanter thanks so much for actively engaging with this package and posing this feature request!

I think this is a completely reasonable request. However, the conventional connector_id is not actually included in the raw incremental_mar table. There is a connector_id field; however, after talking with our connector team, this field is in fact the connector_name. You can see us perform this renaming here. If you explore the raw connector_id field in the incremental_mar source you will notice this field is in fact the connector_name equivalent from the connector raw table.

Unfortunately, my team will be unable to add the true connector_id to the package unless it is added to the raw table synced by the connector. In order to recommend that feature request, I would highly encourage opening a feature request via our support portal. From there, you can collaborate with our product team to discuss the feature and why it would be valuable to include in the source (and downstream package staging models).

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:wontfix This will not be worked on and removed type:enhancement New functionality or enhancement labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants