Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve community_louvain function #2

Open
akimbler opened this issue Apr 16, 2018 · 0 comments
Open

Improve community_louvain function #2

akimbler opened this issue Apr 16, 2018 · 0 comments
Labels
code enhancement New feature or request
Milestone

Comments

@akimbler
Copy link
Member

The description for the community_louvain function is misleading. It is supposed to improve upon and subsume the roles of the modularity_louvain_xxx functions. It does not, however, accept signed connection matrices, so it fails to subsume the signed functions. Resulting in a lot of redundant code and the need for modularity_louvain_xxx_sign functions to still exists.

TL:DR, community_louvain needs to be made to work with signed input

@akimbler akimbler changed the title REFACTORING: community_louvain function CODE: community_louvain function Apr 16, 2018
@tsalo tsalo added the code label Apr 17, 2018
@tsalo tsalo changed the title CODE: community_louvain function Improve community_louvain function Jun 18, 2018
@tsalo tsalo added the enhancement New feature or request label Jun 18, 2018
@tsalo tsalo modified the milestones: 0.0.2, 1.0.0 Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants