forked from ipfs/kubo
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: _redirects support refactored #43
Closed
justindotpub
wants to merge
10
commits into
justincjohnson/redirects-refactoring-1
from
justincjohnson/redirects-after-refactoring
Closed
Draft: _redirects support refactored #43
justindotpub
wants to merge
10
commits into
justincjohnson/redirects-refactoring-1
from
justincjohnson/redirects-after-refactoring
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justindotpub
force-pushed
the
justincjohnson/redirects-after-refactoring
branch
2 times, most recently
from
April 10, 2022 01:35
0ea5550
to
65d3b47
Compare
justindotpub
commented
Apr 10, 2022
go.mod
Outdated
@@ -121,4 +123,6 @@ require ( | |||
golang.org/x/sys v0.0.0-20211025112917-711f33c9992c | |||
) | |||
|
|||
replace github.com/tj/go-redirects => ../go-redirects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t forget to remove this.
justindotpub
force-pushed
the
justincjohnson/redirects-refactoring-1
branch
2 times, most recently
from
April 12, 2022 13:30
ec10aa3
to
01bd73c
Compare
justindotpub
force-pushed
the
justincjohnson/redirects-after-refactoring
branch
from
April 12, 2022 13:32
04de5d9
to
727061b
Compare
…is no root CID to be found
…oo much PR noise - Switch to fission-suite/go-redirects - More experimental ipns path handling logic - Remove unused function args
- Correct the approach to getting root CID when DNSlink is involved
Replaced by ipfs#8890. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with how to refactor
_redirects
support, on top of my general gateway refactoring branch.