Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/reset should redirect to /reset/ or show the same view #83

Closed
jeffgca opened this issue Jul 5, 2021 · 5 comments
Closed

/reset should redirect to /reset/ or show the same view #83

jeffgca opened this issue Jul 5, 2021 · 5 comments

Comments

@jeffgca
Copy link

jeffgca commented Jul 5, 2021

If I go to /reset I just get the default '/' view. I should see the same view as /reset/ instead.

@matheus23
Copy link
Member

This would be easier to implement if we had ipfs/kubo#7392

@jeffgca
Copy link
Author

jeffgca commented Jul 5, 2021

@matheus23 so you're saying it's not impossible to implement? 💯

...I don't understand how the framework works, but usually route aliases are a built-in feature, no?

@bmann
Copy link
Member

bmann commented Jul 5, 2021

It means we have to do a client side redirect, because we can’t rely on the server. Which we should do @matheus23 unless I also am missing something in Elm Land ;)

@matheus23
Copy link
Member

We can totally build this by doing a redirect in javascript.
I just wanted to tag the above issue as it would help with this as well :)
In other words: In case the above issue gets implemented before we get to this, we should use that, I think.

@bmann
Copy link
Member

bmann commented Jul 5, 2021

Native redirects will take a while to get into go-IPFS.

We may be able to get there sooner with our nginx proxy work and do it at that layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants