Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Firehose JS client into npm package #58

Open
bradgessler opened this issue Jun 7, 2016 · 9 comments
Open

Move Firehose JS client into npm package #58

bradgessler opened this issue Jun 7, 2016 · 9 comments

Comments

@bradgessler
Copy link
Member

Break the JS code out of https://github.com/firehoseio/firehose/tree/master/lib/assets/javascripts to https://github.com/firehoseio/firehose/javascript and package up as an NPM package (firehose is taken, so firehose-client?)

@bradgessler
Copy link
Member Author

@steel this issue may be relevant to some of the front end work you're doing.

@steel
Copy link
Member

steel commented Jun 9, 2016

👍

This was referenced Jun 11, 2016
@bakkdoor
Copy link
Member

bakkdoor commented Jun 13, 2016

We should probably merge / base these changes off of the client-side dropped messages callback feature I did as part of #52
See https://github.com/firehoseio/firehose/tree/dropped-messages-callback

@steel
Copy link
Member

steel commented Jun 13, 2016

@bakkdoor can your branch be merged into master?

@steel
Copy link
Member

steel commented Jun 13, 2016

@bradgessler how do you feel about moving the js client out into a separate repo? I can't get TravisCI to run both ruby and js specs easily in 1 go. Plus, I don't think it makes sense to.

@bakkdoor
Copy link
Member

bakkdoor commented Jun 13, 2016

@steel Yeah, I'm going to merge it into master now

@bradgessler
Copy link
Member Author

We'll have to deprecate https://github.com/firehoseio/firehose/blob/master/lib/firehose/cli.rb#L17-L20 in that release. I'm happy with something like:

puts "DEPRECATED: Firehose JavaScripts are now available at https://github.com/firehoseio/..."

@steel
Copy link
Member

steel commented Jun 17, 2016

Moved everything over to https://github.com/firehoseio/js_client and published 1.0

@steel
Copy link
Member

steel commented Nov 14, 2016

We need to deprecate the JS in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants