-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Firehose JS client into npm package #58
Comments
@steel this issue may be relevant to some of the front end work you're doing. |
👍 |
We should probably merge / base these changes off of the client-side dropped messages callback feature I did as part of #52 |
@bakkdoor can your branch be merged into master? |
@bradgessler how do you feel about moving the js client out into a separate repo? I can't get TravisCI to run both ruby and js specs easily in 1 go. Plus, I don't think it makes sense to. |
@steel Yeah, I'm going to merge it into master now |
We'll have to deprecate https://github.com/firehoseio/firehose/blob/master/lib/firehose/cli.rb#L17-L20 in that release. I'm happy with something like:
|
Moved everything over to https://github.com/firehoseio/js_client and published 1.0 |
We need to deprecate the JS in this repo. |
Break the JS code out of https://github.com/firehoseio/firehose/tree/master/lib/assets/javascripts to https://github.com/firehoseio/firehose/javascript and package up as an NPM package (firehose is taken, so firehose-client?)
The text was updated successfully, but these errors were encountered: