Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate message buffer offsets in Redis (not Ruby) #55

Open
bradgessler opened this issue May 20, 2016 · 0 comments
Open

Calculate message buffer offsets in Redis (not Ruby) #55

bradgessler opened this issue May 20, 2016 · 0 comments
Labels

Comments

@bradgessler
Copy link
Member

Instead of grabbing all the messages from the message buffer and calculating offsets in Ruby, do it all on Redis.

The MessageBuffer class is a good place to start. https://github.com/firehoseio/firehose/blob/message-buffer/lib/firehose/server/message_buffer.rb. Be sure the test suite passes for whatever is implemented in place.

The message emitted from this new class should be MessageBuffer::Message objects. This will be compatible with all channel consumers.

Preferably this upgrade is done in a way that's compatible with live production upgrades (e.g. the Lua scripts we load for publishing shouldn't corrupt the message buffer arrays during a rolling restart)

Some work started for this at https://github.com/firehoseio/firehose/tree/message-buffer-redis. This branch may not be necessary depending on how we calculate the offsets for Redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant