Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: trim fields #17

Open
amenk opened this issue Feb 14, 2018 · 6 comments
Open

Feature: trim fields #17

amenk opened this issue Feb 14, 2018 · 6 comments

Comments

@amenk
Copy link

amenk commented Feb 14, 2018

Currently having a option field with the import value " " leads to a notice "undefined index in vendor/magento/module-catalog-import-export/Model/Import/Product/Type/AbstractType.php:508".. should we trim all values?
@amenk
Copy link
Author

amenk commented Feb 27, 2018

Would that be in scope of this module?

@EliasKotlyar
Copy link
Contributor

Hello @amenk ,

I think yes - its a module for general improvements of the normal Magento Import.

@amenk
Copy link
Author

amenk commented Apr 13, 2018

Does anybody have small hint where to put such a trim ? I am happy to implement it then, test, make a PR ...

@amenk
Copy link
Author

amenk commented Aug 6, 2018

push Does anybody have a idea where to put such a trim, I had a look but could not come up with a good place.

@amenk amenk changed the title Small Feature: trim fields Feature: trim fields Apr 4, 2019
@amenk
Copy link
Author

amenk commented Apr 25, 2019

Will try to implement this soon (tomorrow?) /assign amenk

@amenk
Copy link
Author

amenk commented Apr 30, 2019

I found out, that it is not possible to add plugins to the Import source.

That is why I am trying my luck with a core patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amenk @EliasKotlyar