This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 96
Remove webSocketConnection option #1118
Labels
Comments
AnshulMalik
added
help wanted
devtools-launchpad
good first issue
and removed
not-available
labels
Dec 28, 2018
I'm interested in working on this. My understanding: webSocketConnection evaluates to true, should I alter the code with the assumption that websockets will always be used? |
Yes, that's right.
Assume that sockets will always be used. So no longer need to check.
…On Mon, Dec 31, 2018, 02:10 Charles Stocky ***@***.*** wrote:
I'm interested in working on this. My understanding: webSocketConnection
evaluates to true, should I alter the code with the assumption that
websockets will always be used?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHdZvZ8fh2tIz65TuJWa6sh5nEBDPlJzks5u-SSygaJpZM4ZjiAO>
.
|
/claim |
Thanks for claiming the issue! 👋 !!! Please check your email and confirm the invitation Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to 🦊 Debugger team! |
Hey @chrlsstcky Do you need any help on this? Please feel free to ask in slack. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We no longer need firefox proxy since we can just use sockets now. So we can get rid of
webSocketConnection
and the code related to this option.It is currently used at these places: https://github.com/devtools-html/devtools-core/search?utf8=%E2%9C%93&q=webSocketConnection&type=
The text was updated successfully, but these errors were encountered: