Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Remove webSocketConnection option #1118

Open
AnshulMalik opened this issue Dec 28, 2018 · 5 comments
Open

Remove webSocketConnection option #1118

AnshulMalik opened this issue Dec 28, 2018 · 5 comments

Comments

@AnshulMalik
Copy link
Contributor

We no longer need firefox proxy since we can just use sockets now. So we can get rid of webSocketConnection and the code related to this option.

It is currently used at these places: https://github.com/devtools-html/devtools-core/search?utf8=%E2%9C%93&q=webSocketConnection&type=

@chrlsstcky
Copy link

I'm interested in working on this. My understanding: webSocketConnection evaluates to true, should I alter the code with the assumption that websockets will always be used?

@AnshulMalik
Copy link
Contributor Author

AnshulMalik commented Dec 30, 2018 via email

@chrlsstcky
Copy link

/claim

@claim claim bot added the in progress label Dec 31, 2018
@claim
Copy link

claim bot commented Dec 31, 2018

Thanks for claiming the issue! 👋

!!! Please check your email and confirm the invitation

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

@AnshulMalik
Copy link
Contributor Author

Hey @chrlsstcky Do you need any help on this? Please feel free to ask in slack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants