Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FInAT needs a FiniteElement factory function #106

Open
connorjward opened this issue Dec 6, 2024 · 3 comments
Open

FInAT needs a FiniteElement factory function #106

connorjward opened this issue Dec 6, 2024 · 3 comments
Labels

Comments

@connorjward
Copy link

From @dham in FInAT/FInAT#109

In order to move finite elements from UFL into FInAT, we need a function which returns finite elements given cell, family, degree, and potentially variant.

This also requires encoding all that information into FIAT or FInAT elements.

@pbrubeck
Copy link

Could this be solved by #120? We moved tsfc.finatinterface.py into the FIAT repo as finat.element_factory.py. The function create_element converts UFL elements into (cached) finat elements.

@pbrubeck
Copy link

Nevertheless, FInAT elements do not know about the UFL parameters that were used to construct them.

@connorjward
Copy link
Author

I think what we really want is to unify FInAT and UFL elements into a single class that inherits from ufl.AbstractFiniteElement.

I guess your PR does achieve the factory functionality described here but we should be taking this further (in future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants