New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not load certificates if GetCertificate is provided #173

Open

AlexanderMescheryakov wants to merge 1 commit into fiorix:master from AlexanderMescheryakov:allow-certificate-callback

AlexanderMescheryakov commented Oct 27, 2022

Addresses #172


          Do not load certificates if GetCertificate is provided

9fe16ea

paulrozhkin commented Oct 22, 2024

I think this check should be like in the net/http/server.go. It contains:

configHasCert := len(config.Certificates) > 0 || config.GetCertificate != nil
if !configHasCert || certFile != "" || keyFile != "" {
	var err error
	config.Certificates = make([]tls.Certificate, 1)
	config.Certificates[0], err = tls.LoadX509KeyPair(certFile, keyFile)
	if err != nil {
		return err
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet