Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Improve profile module further #1534

Open
5 tasks
cdowding-sl opened this issue Nov 12, 2019 · 0 comments
Open
5 tasks

Improve profile module further #1534

cdowding-sl opened this issue Nov 12, 2019 · 0 comments
Milestone
Improve Profile UX

Comments

@cdowding-sl
Copy link
Contributor

cdowding-sl commented Nov 12, 2019 •
edited
Loading

Feature Request

There are still a few outstanding architectural issues as well as simplifications that can be made to the profile. Additionally validation is not fully complete and could be improved upon.

Tasks

  • Decouple the ui json from the profile
  • Add type validation
  • Add ui to profile mapping
  • Add missing validation: schema version, specific constraint validation
  • Refactor FileReader. CsvInputStreamReader, and NameRetrievalService into the improved architecture

Estimate - 2
@cdowding-sl cdowding-sl added this to the Improve Profile UX milestone Nov 12, 2019
@cdowding-sl cdowding-sl self-assigned this Nov 12, 2019
@ghost ghost unassigned cdowding-sl Jan 10, 2020
ghost pushed a commit that referenced this issue Jan 31, 2020
refactor(#1534): Use composition to control generation behaviour
c77df08
ghost pushed a commit that referenced this issue Jan 31, 2020
refactor(#1534): Refactor profile reading to use injected deserialiser
e51c39c
This was referenced Jan 31, 2020
Merged
Merged
ghost pushed a commit that referenced this issue Jan 31, 2020
refactor(#1534): Refactor profile reading to use injected deserialiser
795be96
ghost pushed a commit that referenced this issue Jan 31, 2020
refactor(#1534): Use composition to control generation behaviour
b4d80f6
ghost pushed a commit that referenced this issue Jan 31, 2020
refactor(#1534): Use composition to control generation behaviour
065cbef
ghost pushed a commit that referenced this issue Jan 31, 2020
refactory(#1534): Remove unnecessary imports
dc2e3fe
ghost pushed a commit that referenced this issue Jan 31, 2020
refactor(#1534): Remove accidentally included deserialisation feature
0b2c8c5
ghost pushed a commit that referenced this issue Jan 31, 2020
Merge pull request #1654 from finos/refactor/1534-composed-generators
f4bbe30 
refactor(#1534): Use composition to control generation behaviour
ghost pushed a commit that referenced this issue Jan 31, 2020
refactory(#1534): Remove redunant import
03d4c98
ghost pushed a commit that referenced this issue Jan 31, 2020
refactor(#1534): Add test scenario for sub-folder file reading
7130791
ghost pushed a commit that referenced this issue Jan 31, 2020
Merge pull request #1655 from finos/refactor/1534-reading-improvements
6f03e58 
refactor(#1534): Refactor profile reading to use injected deserialiser
@ghost ghost mentioned this issue May 15, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Improve Profile UX
Development

No branches or pull requests
1 participant
@cdowding-sl