Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done() never called with error #50

Open
daradermody opened this issue Feb 19, 2021 · 0 comments
Open

done() never called with error #50

daradermody opened this issue Feb 19, 2021 · 0 comments

Comments

@daradermody
Copy link

In these lines:

  check(cmd, err, stdout, stderr);
  if (done) { done(err, stdout, stderr); }

The check() function calls process.exit(1) if err is truthy, which means done() never actually gets called where this has been an error, so this scenario can be handled by the code using this library. Should process.exit() be called only if there is no done function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant