Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the first diffusion step a first class property of LDM & Schedulers #201

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

catwell
Copy link
Member

@catwell catwell commented Jan 19, 2024

Notes:

This changes the interface of SD in a backward-incompatible (but IMO simpler) way, as you can see from the changes in the README:

Screenshot from 2024-01-19 16-48-55

This also fixes #193.

deltheil
deltheil previously approved these changes Jan 19, 2024
Copy link
Contributor

@brycedrennan brycedrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

I must confess I am tempted to try and make the __call__ method in the scheduler stateless but that's a large paradigm shift with questionable value.

    def __call__(
        self,
        x: Tensor,
        noise: Tensor,
        step: int,
        num_steps: int = 50,
        first_step: int = 0,
    ) -> Tensor:

@catwell
Copy link
Member Author

catwell commented Jan 19, 2024

I must confess I am tempted to try and make the call method in the scheduler stateless

It's actually what I had set out to do initially! But yeah I decided against it at least for now.

@catwell catwell requested a review from deltheil January 19, 2024 17:51
@catwell catwell merged commit 8a36c8c into main Jan 19, 2024
1 check passed
@catwell catwell deleted the pr/first-step branch January 19, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants