Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support converting sdwebui Lora format to refiners #116

Closed
brycedrennan opened this issue Nov 16, 2023 · 3 comments
Closed

feature: support converting sdwebui Lora format to refiners #116

brycedrennan opened this issue Nov 16, 2023 · 3 comments

Comments

@brycedrennan
Copy link
Contributor

brycedrennan commented Nov 16, 2023

I got pokemon Lora example working but it seems most loras are in the larger sdwebui format that modifies more than just the unet.

This one for example:
https://civitai.com/models/7109/modern-disney-lora

@brycedrennan brycedrennan changed the title feature: support larger Lora format feature: support converting sdwebui Lora format to refiners Nov 16, 2023
@deltheil
Copy link
Member

[...] it seems most loras are in the larger sdwebui format that modifies more than just the unet

This is a good point! FWIW, applying LoRA layers to the CLIP text encoder and/or the VAE is currently supported. But that would require additional conversion scripts (e.g. even scripts/conversion/convert_diffusers_lora.py has limitations for now)

@catwell
Copy link
Member

catwell commented Jan 29, 2024

@brycedrennan As of now with the new SDLoraManager and the merge of #212 I think the Disney LoRA in your example works. It loads without warning and for instance using the prompt "a magical princess with golden hair, modern disney style" from the official repo, we get without the LoRA:

out-std

and with the LoRA:

out-disney

Do you know of other LoRAs that would not load? Otherwise we can possibly at last close that issue!

@brycedrennan
Copy link
Contributor Author

That's great news! Lets close the issue and if any can't be loaded we can consider the causes separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants