Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaining Exceptions causes tests to throw act error #989

Open
JoeyAtSS opened this issue May 1, 2022 · 0 comments
Open

Chaining Exceptions causes tests to throw act error #989

JoeyAtSS opened this issue May 1, 2022 · 0 comments

Comments

@JoeyAtSS
Copy link

JoeyAtSS commented May 1, 2022

Are you submitting a bug report or a feature request?

Bug report

What is the current behavior?

chaining error result in an act warning that could not be resolved, even though test was completed with the correct behavior.

image

here's how my handleSubmit looks like
`
// In api file
export const fetchSomething = () => {
return fetch('/somewhere')
.then((result) => doSomethingWithResult(result))
.catch((e) => {
alert(e.message);
throw e; // rethrow the error, so that the 2nd then doesnt run
})
}

// in component
const handleSubmit = () => {
return fetchSomething();
.then(() => showSuccessMessage()); // this should only run if the catch dint happen in the api file
.catch(() => {}); // Do nothing since the 1st catch should have stopped the 2nd then, this is just so that all errors are caught
}
`

What is the expected behavior?

No error thrown

Sandbox Link

Sorry, tried to create one in codesandbox.io, but couldn't run the test suite properly.

What's your environment?

React 18, react dome 18, react final form 6.5.9, final form 4.20.7

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant