Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps start to open as a self contained window, the screen stops loading in new window, and instead opens as a tab in main Firefox window #512

Open
ScottYates opened this issue Jun 10, 2024 · 10 comments
Labels
bug Something isn't working question Further information is requested

Comments

@ScottYates
Copy link

Description

Apps start to open as a self contained window, the screen stops loading in new window, and instead opens as a tab in main Firefox window

Steps to Reproduce

  1. Go to voice.google.com or gmail.com and ask PWA to install/open as an application

Affected Websites

Happens on all sites I try. Including those that are set up to BE PWA's

Environment

  • Operating system: Win11
  • System architecture: Ryzen 9 5950x
  • Installation method: MSI
  • PWAsForFirefox extension version: 2.12.1
  • PWAsForFirefox native version: 2.12.1
  • PWAsForFirefox runtime version: 2.12.1
  • Firefox version: 126.0.1 (64-bit)
@ScottYates ScottYates added the bug Something isn't working label Jun 10, 2024
@filips123
Copy link
Owner

Do you have "Open out-of-scope URLs in a default browser" enabled? If so, you need to add SSO domains to the "Domains always allowed to be opened in the app browser" input. You can check the documentation for a list of recommended values.

@ScottYates
Copy link
Author

ScottYates commented Jun 11, 2024

Tried with both true/false in the firefoxpwa.openOutOfScopeInDefaultBrowser, and with * in firefoxpwa.allowedDomains

image

Does not seem to change behavior. voice.google.com for example, opens in the pwa, starts to load, then pops back into the main FF instance while leaving the pwa window stalled.

Is there something else I can do to provide better information?

@ScottYates
Copy link
Author

image

I set it up this way, and try voice.google.com, and it does the same thing.

@filips123
Copy link
Owner

Have you restarted all PWAs after changing these settings? Also, can you try any other PWA that doesn't use Google accounts, maybe GitHub for example?

@ScottYates
Copy link
Author

I did close all PWAs and try again, with the same results. However, it appears to be just the "googly" sites, as github does work.

Please advise.

@filips123
Copy link
Owner

Can you try to install some Google site that causes problems into a new profile (select "Automatically create a new profile" when installing it), and check if it also causes problems there?

@ScottYates
Copy link
Author

That looks like it did the trick. Thank you so much. I wonder if that should go in the FAQ? Maybe I should do a PR?

@filips123
Copy link
Owner

Well, this issue shouldn't even happen, and it doesn't seem to happen often, so it's probably not needed to add it to FAQ now.

@mortenfc
Copy link

I got this issue as well. Didn't have it with previous versions

@filips123
Copy link
Owner

Does it happen even if you have "Open out-of-scope URLs in a default browser" disabled?

@filips123 filips123 added the question Further information is requested label Aug 4, 2024
@filips123 filips123 added question Further information is requested and removed question Further information is requested labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants