Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actionOptions don't properly update in the picker on prop change #96

Open
CalinLeafshade opened this issue Jul 30, 2020 · 0 comments
Open

actionOptions don't properly update in the picker on prop change #96

CalinLeafshade opened this issue Jul 30, 2020 · 0 comments

Comments

@CalinLeafshade
Copy link

Due to the referenced line the action options are cloned in the component constructor and sent to the picker. This means that if they are changed after mounting then the picker inside the state will not use the new action options.

filestack-react/src/ReactFilestack.jsx

Line 50 in c10692a

picker: action === 'pick' ? client.picker({ ...actionOptions, onUploadDone: this.onFinished }) : null,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CalinLeafshade