Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Introduced ViewModels for widget controls #14338

Closed
wants to merge 13 commits into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jan 1, 2024

Summary

  • Added ViewModels for each widget control
  • Get rid of possible null dereference warnings
  • Follow one class per file rule
  • Added Widget prefix to models for widget card items
  • Added SideBar prefix to models for sidebar items
  • Introduced App.Data.Contracts namespace
  • Renamed StatusBarControl to StatusBar
  • Improved WidgetsHelper class
  • Moved code-behind of HomePage to HomeViewMode
  • Renamed IAddressToolbar to IAddressToolbarViewModel
  • Renamed ISearchBox to ISearchBoxViewModel

Task Checklist

Steps To Validate Changes

  1. Launch the app
  2. Go to ...

TODO: Write down

Known Issues

N/A

PR Checklist

  • Development: Closes Code Quality: Refactor Widget controls #13210
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Screenshots

UI Improvements:

  1. Added no items in container message
Before(Stable) After(Dev)
image image
  1. Adjusted ListViewItem's position
Before(Stable) After(Dev)
image image

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@0x5bfa 0x5bfa changed the title Code Quality: Cleanup widget controls Code Quality: Introduced ViewModels for widget controls Jan 2, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a separate PR for the UI changes? This helps the review process and makes it easier to list the improvements in the changelog.

@0x5bfa 0x5bfa closed this Jan 14, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Cleanup-Widgets branch February 13, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Refactor Widget controls
2 participants