Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read scheduled rewards from Station Core metrics #1134

Closed
bajtos opened this issue Nov 22, 2023 · 1 comment · Fixed by #1168
Closed

Read scheduled rewards from Station Core metrics #1134

bajtos opened this issue Nov 22, 2023 · 1 comment · Fixed by #1168
Assignees
@patrickwoodhead
Labels
code-cleanup Tasks making our codebase easier to maintain good first issue 🤗 Good for newcomers

Comments

@bajtos
Copy link
Member

bajtos commented Nov 22, 2023 •
edited
Loading

See the discussion in filecoin-station/core#259

Let's remove Meridian interaction from Station Desktop and rework Station Desktop to read "scheduled rewards" from the metrics emitted by Station Core (see filecoin-station/core#267)
@bajtos bajtos added good first issue 🤗 Good for newcomers code-cleanup Tasks making our codebase easier to maintain labels Nov 22, 2023
@bajtos bajtos mentioned this issue Nov 22, 2023
Merged
@bajtos bajtos moved this to 🗃 backlog in Space Meridian Nov 22, 2023
@patrickwoodhead patrickwoodhead self-assigned this Dec 3, 2023
@patrickwoodhead patrickwoodhead mentioned this issue Dec 4, 2023
Merged
@patrickwoodhead patrickwoodhead linked a pull request Dec 4, 2023 that will close this issue
Read scheduled rewards from core #1168
Merged
@bajtos
Copy link
Member Author

bajtos commented Jan 8, 2024

@patrickwoodhead I think this issue can be closed as done after you land #1168 and we publish a new Station Desktop version, is that correct?

/cc @juliangruber

@bajtos bajtos moved this from 🗃 backlog to 🏗 in progress in Space Meridian Jan 8, 2024
@github-project-automation github-project-automation bot moved this from 🏗 in progress to ✅ done in Space Meridian Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickwoodhead patrickwoodhead

Labels
code-cleanup Tasks making our codebase easier to maintain good first issue 🤗 Good for newcomers
Projects
Space Meridian
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read scheduled rewards from core filecoin-station/desktop
2 participants
@bajtos @patrickwoodhead