Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Inconsistent CLI arguments between inspect-earnings and claim sub-commands #69

Open
vorburger opened this issue Jul 2, 2023 · 1 comment
Open

Minor: Inconsistent CLI arguments between inspect-earnings and claim sub-commands #69

vorburger opened this issue Jul 2, 2023 · 1 comment
Assignees
@AmeanAsad

Comments

@vorburger
Copy link

saturn-contracts inspect-earnings --address $NODE_FIL_ADDRESS --factory-address $CONTRACT_FIL_ADDRESS

VS.

saturn-contracts claim --addr-to-claim $NODE_FIL_ADDRESS --factory-addr $CONTRACT_FIL_ADDRESS --method ...

when perhaps this (TBD) would be more consistent:

saturn-contracts claim --address $NODE_FIL_ADDRESS --factory-address $CONTRACT_FIL_ADDRESS --method ...

BTW https://docs.saturn.tech/claim-your-rewards erroneously show --factory-address instead of (currently) --factory-addr for claim.

@AmeanAsad
@vorburger vorburger changed the title Minor: Inconsistent CLI arguments between inspect-earnings claim Minor: Inconsistent CLI arguments between inspect-earnings and claim sub-commands Jul 2, 2023
@AmeanAsad AmeanAsad self-assigned this Jul 3, 2023
@AmeanAsad
Copy link
Contributor

We should change this for consistency, will publish a PR shortly for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmeanAsad AmeanAsad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vorburger @AmeanAsad