Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verify_signature syscall #2008

Open
Stebalien opened this issue May 8, 2024 · 6 comments
Open

Remove verify_signature syscall #2008

Stebalien opened this issue May 8, 2024 · 6 comments
Milestone

Comments

@Stebalien
Copy link
Member

We now have a new verify_bls_aggregate syscall and can remove the old verify_signature syscall in the next major version.

@rjan90 rjan90 added this to FilOz May 21, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz May 21, 2024
@rjan90
Copy link
Contributor

rjan90 commented Jun 4, 2024

This needs to land after nv23

@Stebalien
Copy link
Member Author

Specifically, this needs to land once we make the next major release of the FVM (which isn't currently planned).

@Stebalien
Copy link
Member Author

Note: we also need to disable this feature in the builtin actors. Once we do that, the builtin actors will no longer be using this syscall and it can be removed entirely in the next major FVM version.

@rvagg
Copy link
Member

rvagg commented Jun 5, 2024

oh, we should do that in builtin-actors to make FIP-0079 complete, right? that should probably go on the nv23 checklist.

@rjan90 rjan90 added this to the NV23 milestone Jun 5, 2024
@Stebalien
Copy link
Member Author

Yeah, although we first need to release a new FVM version (4.3 is the safest). Then we should be able to patch the builtin-actors as follows:

diff --git a/Cargo.toml b/Cargo.toml
index e6166066..c2cca25a 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -121,8 +121,8 @@ frc42_dispatch = "5.0.0"
 frc46_token = "9.0.0"
 
 # FVM
-fvm_sdk = "~4.0"
-fvm_shared = "~4.0"
+fvm_sdk = { version = "~4.3", default-features = false }
+fvm_shared = "~4.3"
 fvm_ipld_encoding = "0.4.0"
 fvm_ipld_blockstore = "0.2.0"
 fvm_ipld_hamt = "0.8.0"

@rvagg
Copy link
Member

rvagg commented Jun 6, 2024

ok, let's wait to get the new ni-porep proofs in and then do a 4.3

@rjan90 rjan90 moved this from 📌 Triage to 🐱Todo in FilOz Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🐱 Todo
Development

No branches or pull requests

3 participants