Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Hamt::load #1828

Closed
Stebalien opened this issue Aug 1, 2023 · 0 comments · Fixed by #1831
Closed

Deprecate Hamt::load #1828

Stebalien opened this issue Aug 1, 2023 · 0 comments · Fixed by #1831
Labels
Kind: Improvement An improvement of something that exists.

Comments

@Stebalien
Copy link
Member

See filecoin-project/builtin-actors#1346.

This method is a lie as it'll just automatically use a bit-width of 8 without checking anything.
@Stebalien Stebalien added the Kind: Improvement An improvement of something that exists. label Aug 1, 2023
@Stebalien Stebalien mentioned this issue Aug 2, 2023
Merged
Stebalien added a commit that referenced this issue Aug 2, 2023
@Stebalien
chore: deprecate default bitwidths in the KAMT/AMT
f42072d 
1. We don't intentionally use these anywhere.
2. We _do_ unintentionally use these where we
shouldn't (filecoin-project/builtin-actors#1346).

fixes #1828
@Stebalien Stebalien mentioned this issue Aug 2, 2023
Merged
Stebalien added a commit that referenced this issue Aug 3, 2023
@Stebalien
chore: deprecate default bitwidths in the KAMT/AMT (#1831)
bada773 
1. We don't intentionally use these anywhere.
2. We _do_ unintentionally use these where we
shouldn't (filecoin-project/builtin-actors#1346).

fixes #1828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind: Improvement An improvement of something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deprecate default bitwidths in the KAMT/AMT filecoin-project/ref-fvm
1 participant
@Stebalien