Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor events: validate that entry values are structurally correct DAG-CBOR #1082

Open
raulk opened this issue Nov 14, 2022 · 0 comments
Open

Comments

@raulk
Copy link
Member

raulk commented Nov 14, 2022

Ideally we would strive for zero-copy validation. Validating some DAG-CBOR constraints make this difficult (e.g. checking that integers are minimally encoded, or that CIDs are well formed), but it's definitely better than eagerly allocating whatever struct the user passes.

See an initial stab at an implementation here: ipld/libipld#159. We should probably make it iterative instead of recursive for extra safety; I have ideas.

This is more relevant for M2.2 than it is now, since user events will be emitted through the EVM built-in actor. It may reduce footguns if we start emitting events from other built-in actors prior to M2.2, but we can decide then.

@raulk raulk added this to the M2.2 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant