Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lotus-shed backfill events doesn't touch events_seen #12334

Closed
rvagg opened this issue Aug 2, 2024 · 0 comments · Fixed by #12335
Closed

lotus-shed backfill events doesn't touch events_seen #12334

rvagg opened this issue Aug 2, 2024 · 0 comments · Fixed by #12335

Comments

@rvagg
Copy link
Member

rvagg commented Aug 2, 2024

We forgot to update backfilling when we landed #12080. If you run backfill-events after that migration (1.28) then it's not going to update the table that we need to determine if we've processed that tipset.

We're going to nuke the lotus-shed backfilling, see conversation in #12330 and #12116, but for now it's still used and it should work.

We need to copy this logic:

// this statement will mark the tipset as processed and will insert a new row if it doesn't exist
// or update the reverted field to false if it does
_, err = tx.Stmt(ei.stmtUpsertEventsSeen).Exec(
te.msgTs.Height(),
tsKeyCid.Bytes(),
)
if err != nil {
return xerrors.Errorf("exec upsert events seen: %w", err)
}

Into the bottom of this closure:

processHeight := func(ctx context.Context, cnt int, msgs []lapi.Message, receipts []*types.MessageReceipt) error {

@rjan90 rjan90 added this to FilOz Aug 2, 2024
@rjan90 rjan90 moved this to ⌨️In Progress in FilOz Aug 2, 2024
@rjan90 rjan90 moved this from ⌨️In Progress to 🎉 Done in FilOz Aug 5, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️Done (Archive) in FilOz Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging a pull request may close this issue.

1 participant