Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivateDeals types are wrong #225

Open
arajasek opened this issue Oct 12, 2023 · 3 comments
Open

ActivateDeals types are wrong #225

arajasek opened this issue Oct 12, 2023 · 3 comments

Comments

@arajasek
Copy link
Contributor

The result is wrong here, and I think the ActivateDealsResult itself is wrong too.

Low impact.
@arajasek
Copy link
Contributor Author

Compare with correct values here https://github.com/filecoin-project/builtin-actors/blob/b67d97e40584cb9a2b6883bbd8b0526c41d13ae2/actors/market/src/types.rs

@remakeZK
Copy link

Same errors happen in here , the types has changed in filecoin-project/builtin-actors@1b282d4

@Terryhung
Copy link

Hi @arajasek , is there any update here?

@rjan90 rjan90 added this to FilOz Jan 31, 2024
@rjan90 rjan90 moved this to 🐱Todo in FilOz Jan 31, 2024
@rjan90 rjan90 removed the status in FilOz Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
FilOz
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Terryhung @arajasek @remakeZK