Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarshalCBOR should fail with a signature >=SignatureMaxLength, which will fail to decode #21

Open
wadealexc opened this issue Jan 15, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@wadealexc
Copy link

UnmarshalCBOR limits payload to 200 bytes (SigType plus Data), but MarshalCBOR will serialize a signature that would fail to decode for this reason.

if l > SignatureMaxLength {
return fmt.Errorf("string too long")
}

@anorth anorth added the bug Something isn't working label Jan 17, 2021
@anorth anorth added this to the 🧡 v3 milestone Jan 17, 2021
@rjan90 rjan90 added this to FilOz Jun 18, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz Jun 18, 2024
@rjan90 rjan90 removed the status in FilOz Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants