Impossible to carry non-utf8 market labels over API boundaries

[ribasushi]

Because the JSON marshaller ignores the Bytes datamodel type, whenever one uses a non-utf8 ([]byte) label it is stripped off during RPC (JSON) transport

https://github.com/filecoin-project/go-state-types/blob/v0.10.0/builtin/v10/market/deal.go#L166-L168
+
https://github.com/filecoin-project/go-state-types/blob/v0.10.0/builtin/v10/market/deal.go#L184-L187

@arajasek @magik6k Is this intentional? If not any objections I fix it?

[arajasek]

@ribasushi Definitely not intentional, please fix.

[ribasushi]

@arajasek actually seems intentional... can you double-confirm? #43

[ZenGround0]

FIP 0027 is relevant.

[rjan90]

Its a bit unclear if this is still impacting Lotus anymore as we have removed the legacy markets, but it might be impacting Boost. So worth checking in with Curio on this.

We are not actively going to fix this, unless we find out if this has a larger impact for DX.

[rvagg]

Really easy fix here would be to break in to dag-json in this field when it's bytes, "label": "a string label", vs "label": {"/":{"bytes":"AAAAAAAA8D8AAAAAAAAAQAAAAAAAAAjA"}}.

The alternative is to go with the standard Go route of base64 encoding this, but then you lose the signal about whether it's bytes or string.

@ribasushi what did you have in mind for a fix for this?

[ribasushi]

I do not have interest in this bugreport anymore: DDO made the entire label construct obsolete. It is definitely a bug with the JSON serialization of the struct, but yeah: feel free to close.