Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock runtime should not return ActorError for expectation violations #196

Closed
anorth opened this issue Apr 7, 2022 · 0 comments · Fixed by #246 · May be fixed by #197
Closed

Mock runtime should not return ActorError for expectation violations #196

anorth opened this issue Apr 7, 2022 · 0 comments · Fixed by #246 · May be fixed by #197
Labels

Comments

@anorth
Copy link
Member

anorth commented Apr 7, 2022

The mock runtime returns ActorError with bogus exit codes in the case of some expectation violations. This is totally wrong – it should immediately fail the test instead. The mock should return an ActorError only in those cases where it's replicating an ActorError returned by the FVM runtime layer.

This is probably an artefact of the Runtime interface methods returning ActorError, which for the most part is inappropriate.

cc @dignifiedquire @Stebalien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1 participant