Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Array type alias with abstraction #1529

Open
anorth opened this issue Mar 7, 2024 · 0 comments
Open

Replace Array type alias with abstraction #1529

anorth opened this issue Mar 7, 2024 · 0 comments
Assignees
Labels
cleanup help wanted Extra attention is needed

Comments

@anorth
Copy link
Member

anorth commented Mar 7, 2024

The Array type is just an alias for AMT. This lack of abstraction can lead to issues like #1346. Also, exposing the amt package errors directly causes a bunch of bloat in users that need to wrap and attach exit codes.

Create an Array2 type following the same pattern as Map2 and replace all uses of Array. Simplify all the map_err wrapping points that result from amt errors.

We can rename Array2 to Array once that name becomes available again.

@anorth anorth added help wanted Extra attention is needed cleanup labels Mar 7, 2024
@aarshkshah1992 aarshkshah1992 self-assigned this Mar 8, 2024
@rjan90 rjan90 added this to FilOz Mar 8, 2024
@rjan90 rjan90 moved this to ⌨️In Progress in FilOz Mar 8, 2024
@rjan90 rjan90 moved this from ⌨️In Progress to 🐱Todo in FilOz Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup help wanted Extra attention is needed
Projects
Status: 🐱 Todo
Development

No branches or pull requests

2 participants