You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently owner & worker can be set to whichever address upon creating miners, with no checks. This means that one create as many miners as he/she would like for any addresses.
This can bring possible harm i.e. possiblity mistaking real & fake miners / annoying when browsing owner info on explorer and possible token loss.
On the other hand this brings logic inconsistency comparing to owner changing: permission from new owner is needed upon owner changing, while permission from new owner is not needed upon miner creation.
Suggestion: checks owner & worker exactly the same as msg sender upon creating miners.
The text was updated successfully, but these errors were encountered:
jinqiao0423
changed the title
Check upon creating miners?
Check owner & worker same as msg sender upon creating miners?
Nov 9, 2023
Currently owner & worker can be set to whichever address upon creating miners, with no checks. This means that one create as many miners as he/she would like for any addresses.
This can bring possible harm i.e. possiblity mistaking real & fake miners / annoying when browsing owner info on explorer and possible token loss.
On the other hand this brings logic inconsistency comparing to owner changing: permission from new owner is needed upon owner changing, while permission from new owner is not needed upon miner creation.
Suggestion: checks owner & worker exactly the same as msg sender upon creating miners.
The text was updated successfully, but these errors were encountered: