Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for automatic cron-processing of deals #1389

Open
alexytsu opened this issue Aug 30, 2023 · 1 comment
Open

Remove tests for automatic cron-processing of deals #1389

alexytsu opened this issue Aug 30, 2023 · 1 comment
Labels
cleanup

Comments

@alexytsu
Copy link
Contributor

Legacy deals that are automatically settled by cron are handled as before. They continue to be processed in cron and are rescheduled until they are expired.

However, since new deals are handled by the provider-initiated Market::SettleDealPayments flow, the code in market::cron_tick can be simplified and tests protecting this behaviour also dropped.
@alexytsu
Copy link
Contributor Author

Must be done after #1377 is live and all legacy deals have been processed. i.e. there should be no more active deals in cron's processing queue.

@alexytsu alexytsu mentioned this issue Aug 30, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexytsu