Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle events in the TestVM #1336

Open
anorth opened this issue Jul 19, 2023 · 1 comment
Open

Handle events in the TestVM #1336

anorth opened this issue Jul 19, 2023 · 1 comment
Assignees

Comments

@anorth
Copy link
Member

anorth commented Jul 19, 2023

The integration TestVM doesn't handle actor events. PR #1320 collects them in invocation context, but does not make them available for inspection by test code. Consider some of the following paths:

  • Add events to MessageResult, as the are present in the top-level message receipt on chain
  • Add events to entries in the InvocationTrace, where their provenance can be inspected in more detail

Either of these should be coordinated with ongoing efforts to provide an abstract integration testing interface that can support testing on either a real VM or the TestVM (see #1236 and others).

FYI @Stebalien @alexytsu

@anorth
Copy link
Member Author

anorth commented Jan 22, 2024

@aarshkshah1992 I think you make have completed this. Please close the issue if you believe so, or leave a comment here explaining what still needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants