Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV18: Implement state checks for new actors #1189

Open
arajasek opened this issue Feb 9, 2023 · 3 comments
Open

NV18: Implement state checks for new actors #1189

arajasek opened this issue Feb 9, 2023 · 3 comments

Comments

@arajasek
Copy link
Contributor

arajasek commented Feb 9, 2023

These are currently unimplemented for the 4 new actors: https://github.com/filecoin-project/builtin-actors/blob/next/state/src/check.rs#L223-L226. For actors where no state check is possible, explicitly say so in a comment.

Also examine the init actor's state check for any necessary updates.

@arajasek
Copy link
Contributor Author

arajasek commented Feb 9, 2023

Note that Lotus has already implemented some of these in Go in order to sanity check the nv18 changes: https://github.com/filecoin-project/go-state-types/tree/master/builtin/v10.

@jennijuju
Copy link
Member

is this still needded?

@anorth
Copy link
Member

anorth commented Feb 26, 2023

is this still needded?

If they're not done yet, yes.

@aarshkshah1992 aarshkshah1992 self-assigned this Oct 10, 2023
@aarshkshah1992 aarshkshah1992 removed their assignment Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants