fix: disable leveldb as LID default #1681

LexLuthr · 2023-09-07T12:05:32Z

Tested on devnet

2023-09-07T16:01:53.112+0400	ERROR	fxlog	fxevent/zap.go:59	start failed	{"error": "starting local index directory client:either LocalIndexDirectory.Yugabyte{} details must be defined or LocalIndexDirectory.Leveldb must be enabled"}
Error: creating node: starting node: starting local index directory client:either LocalIndexDirectory.Yugabyte{} details must be defined or LocalIndexDirectory.Leveldb must be enabled

dirkmc

Looks great 👍

Just one suggestion to clarify the error message wording.

node/modules/piecedirectory.go

Co-authored-by: dirkmc <[email protected]>

LexLuthr added 3 commits September 7, 2023 16:04

disable leveldb as LID default

dcd211d

fix docsgen and itests

3b78cf6

fix itest

a1f398b

LexLuthr requested a review from dirkmc September 7, 2023 12:51

dirkmc approved these changes Sep 7, 2023

View reviewed changes

node/modules/piecedirectory.go Outdated Show resolved Hide resolved

Update node/modules/piecedirectory.go

501e637

Co-authored-by: dirkmc <[email protected]>

LexLuthr merged commit 3140f5f into main Sep 7, 2023
1 check passed

LexLuthr deleted the fix/lid-no-def-db branch September 7, 2023 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: disable leveldb as LID default #1681

fix: disable leveldb as LID default #1681

LexLuthr commented Sep 7, 2023

dirkmc left a comment

fix: disable leveldb as LID default #1681

fix: disable leveldb as LID default #1681

Conversation

LexLuthr commented Sep 7, 2023

dirkmc left a comment

Choose a reason for hiding this comment