Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal JS conflict in RelationManagers #14700

Open
gregoryloichot opened this issue Nov 4, 2024 · 2 comments
Open

Modal JS conflict in RelationManagers #14700

gregoryloichot opened this issue Nov 4, 2024 · 2 comments
Labels

Comments

@gregoryloichot
Copy link

gregoryloichot commented Nov 4, 2024

Package

filament/tables

Package Version

v3.2.122

Laravel Version

v11.30

Livewire Version

No response

PHP Version

PHP 8.2

Problem description

Let's say we have a relation manager with a custom column. In this column, we want to add a button that opens a modal window.
This works when there are no actions in the relation manager (it is possible to open the modal window). If there are actions present (in Edit mode, for example) in the relation manager, then the modal window contained in the custom column no longer works.

If this Title Custom column is added in a table (not a relation manager), it works as expected (even in Edit mode).

Expected behavior

The modal window should open under all circumstances.

Steps to reproduce

  1. Clone the project.
  2. Go to /admin/articles/1 (View Mode) -> Click on buttons "Comment 1" and "Comment 2" : a modal is opened.
  3. Go to /admin/articles/1/edit (View Mode) -> Click on buttons "Comment 1" and "Comment 2" : nothing happens.

Reproduction repository (issue will be closed if this is not valid)

https://github.com/gregoryloichot/filament-modal-issue

Relevant log output

In edit mode, JS errors in the browser:

Alpine Expression Error: isOpen is not defined
Expression: "isOpen"
<div x-cloak="" x-show="isOpen">

Alpine Expression Error: isOpen is not defined
Expression: "isOpen"
<div class="fi-modal-close-overlay f…/50 dark:bg-gray-950/75" aria-hidden="true" x-show="isOpen" x-transition.duration.300ms.opacity="">

Uncaught ReferenceError: isOpen is not defined

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@wpalani
Copy link

wpalani commented Nov 25, 2024

I'm facing a similar issue, have you found a solution to yours?

@gregoryloichot
Copy link
Author

I'm facing a similar issue, have you found a solution to yours?

Hi,

I don't… I've reorganized my UI to avoid this situation, but I hope a solution to be found; this is only a workaround for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants