Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberFormatException: null - for additional_info.original_amount #43

Open
JohannesHome opened this issue Aug 29, 2017 · 7 comments
Open
Labels

Comments

@JohannesHome
Copy link

I'm getting a NumberFormatException when deserializing the TransactionsResponse response from /rest/accounts/${id}/transactions for some users.

AdditionalTransactionInfo expects BigDecimal. But the response I'm getting looks like this:

      "additional_info": {
        "compensation_amount": "6,10",
        "original_amount": "575,40"
      }

I assume this is a bug?

@berend
Copy link
Contributor

berend commented Aug 29, 2017

Yes, that looks like a bug. Looks like a String to BigDecimal is missing.

@berend berend added the bug label Aug 29, 2017
@berend
Copy link
Contributor

berend commented Sep 5, 2017

Sorry for the delay, debugging this revealed some differences from bank to bank while parsing this. Only solution we have so far is rolling back to sdk version 1.5.1

@berend
Copy link
Contributor

berend commented Sep 5, 2017

Also the bug is not a missing cast from string to decimal, but the value containing a comma , instead of a dot .

@berend
Copy link
Contributor

berend commented Mar 16, 2018

fixed with #44

@berend berend closed this as completed Mar 16, 2018
@JohannesHome
Copy link
Author

Hey @berend, sorry to say this but I just looked at #44 and that PR actually simply swallows now the values.

So the following:

        "compensation_amount": "6,10",
        "original_amount": "575,40"

results now in null values Instead of an exception.

@berend
Copy link
Contributor

berend commented Mar 16, 2018

Thanks for the feedback, I will look into this!

@berend berend reopened this Mar 16, 2018
@berend
Copy link
Contributor

berend commented Apr 3, 2018

We have some internal dependencies for this bug here. Some of our bank connector return , instead of ., we are fixing this on the API side, not on the SDK. This should only affect a small number of banks.

I am leaving this open until this is completely fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants