-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] All devmod modules should be sent by conformance client in message 68 and to be accepted by conformance owner #75
Comments
To add more detail to this bug report, the reason that the error reads as all mandatory SIMs missing despite them all being sent (in a single message) is due to the fact that the code only gathers the SIMs from messages where IsMoreServiceInfo=true. Therefore, the conformance tests are implicitly requiring that >1 message from the device must be sent and the last message (the one with IsMoreServiceInfo=false) must be empty, as any devmod SIMs will be ignored. This bug has now been reproduced with a different client implementation that sends the SIMs over two messages, sending the "devmod:modules" KV in the second message. Because the second message has IsMoreServiceInfo=false, the error message instead only indicates "devmod:modules" as a missing required SIM. I will open a very simple PR to address the bug in the conformance test. |
To simplify issue resolution process, please provide network logs, and or test voucher.
conformance_client_devmod_sims_log.txt
What part of the spec are you testing?
What protocol are having issue with?
Issue description
Custom Client with conformance owner
Conformance Client with Custom Owner
Tested on commit 7a94396
The text was updated successfully, but these errors were encountered: