Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the test suite to detect potential server errors when the same challenge is used for different users #766

Open
5 of 17 tasks
DavidGonzalezPineiro opened this issue Aug 2, 2024 · 0 comments
Assignees
Labels
Enhancement Improvements to the existing functionality

Comments

@DavidGonzalezPineiro
Copy link

By submitting this issue you are acknowledging that any information regarding this issue will be publicly available.

If you have privacy concerns, please email [email protected]

FIRST PRE CHECK

  • I SOLEMNLY SWEAR THAT I HAVE SEARCHED DOCUMENTATION AND WAS NOT ABLE TO RESOLVE MY ISSUE

What protocol are you implementing?

  • FIDO2 Server
  • CTAP2.0
  • CTAP2.1
  • UAF 1.1
  • U2F 1.1
  • U2F 1.2

NOTE: UAF 1.0 certification have been officially sunset. U2F 1.2 only supported version of U2F.

What is your implementation class?

  • Security Key / FIDO2 / U2F authenticators
  • Server
  • UAF Client-ASM-Authenticator combo
  • UAF Client
  • UAF ASM-Authenticator

If you are platform authenticator vendor, please email [email protected]

What is the version of the tool are you using?

v1.7.19-1

What is the OS and the version are you running?

For desktop tools

  • OSX
  • Windows
  • Linux

For UAF mobile tools

  • iOS
  • Android

Issue description

Enhancing the test suite to verify that the assertion returns an error when different users use the same challenge could be beneficial.

After passing the certification testing tools with 100% accuracy on all the test suite, we identified that a false positive might be possible in the FIDO2 Interop tests.

The test case is as follows:

  1. Register two users by performing a MakeCredential with RK (USER1, USER2).
  2. Perform a GetAssertion with RK:
    2.1. Perform a POST assertion/options request with USER1.
    2.2. Perform a POST assertion/result request with USER2.

If the server does not handle the challenges correctly, the test result may be a false positive. It would be beneficial to include a test in the certification testing tool to check this behavior.

@iirachek iirachek self-assigned this Aug 5, 2024
@iirachek iirachek added the Enhancement Improvements to the existing functionality label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to the existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants