We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While trying to use skycoin/services#6, with the seed, generated by skycoin/services#12, I have found following issues:
Docs for wallet.NewWallet claims that wallet generates a random seed if seed is "". Also it does not mention which encoding is expected.
wallet.NewWallet
However:
wallet.NewWallet returns error if seed is "" - https://github.com/skycoin/skycoin/blob/feaab10d4f951b8ffea53ef2d37a4cf5e3450b17/src/wallet/wallet.go#L80-L82
Wallet.GenerateAddresses does not check for empty seed and on the first pass does not generate new one. Also, on the first pass it converts seed directly to byte representation, while the rest of the code assumes that seed is hex-encoded. https://github.com/skycoin/skycoin/blob/feaab10d4f951b8ffea53ef2d37a4cf5e3450b17/src/wallet/wallet.go#L212-L225
Wallet.GenerateAddresses
wallet.NewService uses bip39 to generate wallet's seed and does not encode it to hex. https://github.com/skycoin/skycoin/blob/feaab10d4f951b8ffea53ef2d37a4cf5e3450b17/src/wallet/service.go#L52-L61
The text was updated successfully, but these errors were encountered:
No branches or pull requests
While trying to use skycoin/services#6, with the seed, generated by skycoin/services#12, I have found following issues:
Docs for
wallet.NewWallet
claims that wallet generates a random seed if seed is "". Also it does not mention which encoding is expected.However:
wallet.NewWallet
returns error if seed is "" - https://github.com/skycoin/skycoin/blob/feaab10d4f951b8ffea53ef2d37a4cf5e3450b17/src/wallet/wallet.go#L80-L82Wallet.GenerateAddresses
does not check for empty seed and on the first pass does not generate new one. Also, on the first pass it converts seed directly to byte representation, while the rest of the code assumes that seed is hex-encoded.https://github.com/skycoin/skycoin/blob/feaab10d4f951b8ffea53ef2d37a4cf5e3450b17/src/wallet/wallet.go#L212-L225
wallet.NewService uses bip39 to generate wallet's seed and does not encode it to hex.
https://github.com/skycoin/skycoin/blob/feaab10d4f951b8ffea53ef2d37a4cf5e3450b17/src/wallet/service.go#L52-L61
The text was updated successfully, but these errors were encountered: