Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Subscriptions.cs #53

Open
wmaethner opened this issue May 6, 2019 · 1 comment
Open

Cleanup Subscriptions.cs #53

wmaethner opened this issue May 6, 2019 · 1 comment
Assignees
@wmaethner
Labels
enhancement New feature or request

Comments

@wmaethner
Copy link
Collaborator

There are six different Subscription classes in Subscriptions.cs which makes things pretty confusing. The differences mainly seem to enable proper binding based on the web call (subscribe, verification, notification, etc). It seems like there should be a way to clean this up and have fewer classes where maybe which properties are bound depend on the call, or something along those lines so that we can reduce the number of classes there are.
@wmaethner wmaethner added enhancement New feature or request good first issue Good for newcomers labels May 6, 2019
This was referenced May 7, 2019
Merged
Closed
@wmaethner
Copy link
Collaborator Author

#56

@wmaethner wmaethner removed the good first issue Good for newcomers label May 9, 2019
@wdvr wdvr mentioned this issue May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmaethner wmaethner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wmaethner