Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is sample_n described earlier? Use instead of slice_sample #161

Open
avahoffman opened this issue Sep 20, 2024 · 3 comments
Open

Is sample_n described earlier? Use instead of slice_sample #161

avahoffman opened this issue Sep 20, 2024 · 3 comments
Assignees
@avahoffman
Labels
Data Classes priority

Comments

@avahoffman
Copy link
Contributor 

          - [ ] Is `sample_n` described earlier? Use instead of `slice_sample`

Originally posted by @avahoffman in #148 (comment)
@avahoffman avahoffman mentioned this issue Sep 20, 2024
Merged
@carriewright11
Copy link
Contributor

carriewright11 commented Sep 30, 2024 •
edited
Loading

slice_sample() is introduced in the subsetting lecture. sample_n() has been superseded in favor of slice_sample()

@carriewright11
Copy link
Contributor

The subsetting lecture is before the data classes lecture, where you wrote this comment, so it will have already been introduced.

@avahoffman
Copy link
Contributor Author

Ok Great. This was part of a code review for @ehumph -- whoever gets to it first, let's get this fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avahoffman avahoffman

Labels
Data Classes priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avahoffman @carriewright11