Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate DerivedQuantities.show_units #860

Open
RemDelaporteMathurin opened this issue Aug 2, 2024 · 0 comments · May be fixed by #892
Open

Deprecate DerivedQuantities.show_units #860

RemDelaporteMathurin opened this issue Aug 2, 2024 · 0 comments · May be fixed by #892
Labels
enhancement New feature or request
Milestone
1.4

Comments

@RemDelaporteMathurin
Copy link
Collaborator

We need to remove the show_units argument of DerivedQuantities.

show_units=True will be the new behaviour.
@RemDelaporteMathurin RemDelaporteMathurin added the enhancement New feature or request label Aug 2, 2024
@RemDelaporteMathurin RemDelaporteMathurin added this to the 1.4 milestone Aug 2, 2024
@RemDelaporteMathurin RemDelaporteMathurin linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

New default value for DerivedQuantities.show_units festim-dev/FESTIM
1 participant
@RemDelaporteMathurin