-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict log access #17
Comments
I understand your point. Some thoughts on this:
Suggestion:
|
Thanks a lot for your response!
Since you are the owner of the project, it is your decision if you add it as a default case or not. In my opinion, restricted access should be the default case following the Privacy by Default principles. Otherwise, the following thought wouldn't be satisfied:
Moreover, I don't see the advantages of having a publicly available |
As said: Reason for log.json file is:
After you usually use this, when you are not in the subnet of the dynamic IP address this might be helpful. If you don't need this, please use .env to turn logging and debugging of. Et voila, no more information. I'll leave this open to investigate on the history a little further as soon as I find some time, because a feature to restrict historian access is necessary. |
Personal choice imho, as for the feature: I added a configuration script to my fork / PR that interactively asks you many of those questions. Also added a deny block for nginx users to the examples and as message in the script. As for me, default should imho be to discourage public log access but inform and empower the user to do whatever they please. |
When running the application, everyone can get detailed information like personal IP address, failures etc. by accessing the log files (just visit
/log.json
in a browser). Access to the log file should be restricted and only visible by admins.The text was updated successfully, but these errors were encountered: