Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): unknown schemas dont need additional properties to be true #5345

Merged

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Dec 5, 2024

Description

Unknown schemas can have any key,value pairs, therefore additional properties: true is unnecessary (and actually degrades API Playground experience).

Changes Made

  • When casting to unknown, additionalProperties is set to false.

Testing

  • Unit tests added/updated
  • Manual testing completed

@dsinghvi dsinghvi marked this pull request as ready for review December 5, 2024 15:53
Copy link

github-actions bot commented Dec 5, 2024

🌿 Preview your docs: https://fern-preview-93bf42b9-0e77-46ac-8180-0e12d2bf6950.docs.buildwithfern.com/learn

@dsinghvi dsinghvi merged commit 9f9b62e into main Dec 5, 2024
53 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/dont-unnecessarily-set-additional-properties-true branch December 5, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant