From 349d1b0d1a21774b04fd256c777fbe246467327b Mon Sep 17 00:00:00 2001 From: "tommy(Chung-il)" Date: Wed, 13 Sep 2023 01:50:09 +0900 Subject: [PATCH 1/2] refactor: update issue and PR templates for English localization (#10) ## Summary - Localized issue and PR templates from Korean to English. - Simplified content for clarity and brevity. ## Checks Please check the following: - [x] I have written documents and tests, if needed. --- .github/ISSUE_TEMPLATE/1-bug-report.yml | 74 ++++++++++---------- .github/ISSUE_TEMPLATE/2-feature-request.yml | 39 ++++++----- .github/PULL_REQUEST_TEMPLATE.md | 24 +++---- 3 files changed, 68 insertions(+), 69 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1-bug-report.yml b/.github/ISSUE_TEMPLATE/1-bug-report.yml index 8a1a655..4fdf8f2 100644 --- a/.github/ISSUE_TEMPLATE/1-bug-report.yml +++ b/.github/ISSUE_TEMPLATE/1-bug-report.yml @@ -1,37 +1,39 @@ -name: fepack 버그 레포트 -description: 문제 상황과 관련된 버그를 보고하는데 사용합니다. +--- +name: "Bug Report" +about: Report a reproducible bug or regression in fepack. title: "bug: " -labels: ["bug"] -body: - - type: markdown - attributes: - value: "## Issue Title\n" - - - type: textarea - attributes: - label: "문제 상황" - description: "어떤 문제가 발생했는지 구체적으로 기술하세요. 가능하다면, 문제가 언제, 어떻게 발생하는지를 포함한 상황을 자세히 설명해주세요." - validations: - required: true - - - type: textarea - attributes: - label: "기대하는 동작" - description: "문제 상황이 발생하지 않았을 때 어떤 동작을 기대했는지 설명해주세요." - validations: - required: true - - - type: textarea - attributes: - label: "스크린샷" - description: "문제 상황을 보여주는 스크린샷이 있다면 첨부해주세요." - - - type: textarea - attributes: - label: "제안하는 해결 방법" - description: "문제를 해결할 수 있는 방법이 있다면 제시해주세요." - - - type: textarea - attributes: - label: "추가 정보" - description: "문제 상황과 관련하여 추가적인 정보가 있다면 기입해주세요." +labels: "bug" +--- + + + +fepack version: + +## Steps To Reproduce + +1. +2. + + + +Link to code example: + + + +## The current behavior + + +## The expected behavior diff --git a/.github/ISSUE_TEMPLATE/2-feature-request.yml b/.github/ISSUE_TEMPLATE/2-feature-request.yml index 1baf6e3..20af9e0 100644 --- a/.github/ISSUE_TEMPLATE/2-feature-request.yml +++ b/.github/ISSUE_TEMPLATE/2-feature-request.yml @@ -1,20 +1,25 @@ -name: fepack 기능 추가 제보 -description: 새로운 기능 제안 또는 기존 기능의 개선을 제보하는데 사용합니다. +--- +name: "Feature Request" +about: Suggest a new feature or an enhancement to an existing one. title: "feat: " -labels: ["enhancement"] -body: - - type: markdown - attributes: - value: "## Issue Title\n" +labels: "enhancement" +--- - - type: textarea - attributes: - label: "기능 설명" - description: "추가하거나 개선하고자 하는 기능에 대해 구체적으로 기술하세요." - validations: - required: true + - - type: textarea - attributes: - label: "추가 정보" - description: "기능 추가 제안과 관련하여 추가적인 정보가 있다면 기입하세요." +## Feature Description: + + + + +## Additional Information: + + diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 96e12a3..7891fe5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,23 +1,15 @@ -## Related Issue +## Summary - + -## Changes + - +## Checks -## Screenshots + - + -## To Reviewer +Please check the following: - - -## Additional Context(optional) - - - -## How Has This Been Tested? - - +- [ ] I have written documents and tests, if needed. From c08a0634450f7a8891c7a2391e3d37bd3bcdf5dc Mon Sep 17 00:00:00 2001 From: "tommy(Chung-il)" Date: Wed, 13 Sep 2023 01:51:52 +0900 Subject: [PATCH 2/2] feat: automatic PR labeling using actions/labeler@v4 (#9) ## Related Issue #8 ## Changes Pull Request Labeler to automate label assignment based on the file changes in PRs. https://github.com/actions/labeler Co-authored-by: Jonghyeon Ko --- .github/labeler.yml | 15 +++++++++++++++ .github/workflows/labeler.yml | 12 ++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 .github/labeler.yml create mode 100644 .github/workflows/labeler.yml diff --git a/.github/labeler.yml b/.github/labeler.yml new file mode 100644 index 0000000..ab76ca1 --- /dev/null +++ b/.github/labeler.yml @@ -0,0 +1,15 @@ +"@fepack/image": + - packages/image/* +documentation: + - websites/documentation/* + - "**/*.md" +eslint: + - configs/eslint-config/* +tsconfig: + - configs/tsconfig/* + - tsconfig.json +dependencies: + - pnpm*.yaml + - package*.json +github: + - .github/* diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml new file mode 100644 index 0000000..857cfb4 --- /dev/null +++ b/.github/workflows/labeler.yml @@ -0,0 +1,12 @@ +name: "Pull Request Labeler" +on: + - pull_request_target + +jobs: + triage: + permissions: + contents: read + pull-requests: write + runs-on: ubuntu-latest + steps: + - uses: actions/labeler@v4